-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyrillic L (Л) replaced by 'n' when searching #4025
Comments
The same bug is on Windows 10 too. Can anybody else reproduced this? I checked another symbols but all symbols except 'л' are rendered correctly. |
Yep, can reproduce it, though it does not highlight "n" for me but still finds notes containing "n". |
Tracked down to these lines in No idea why is it changing "л" to "n", does not make any sense to me, it has nothing to do with diacritics |
Ah! There's even an issue for this: andrewrk/node-diacritics#32 |
@roman-r-m Thanks for the investigation. |
I don't know javascript, but i've found that Joplin contains its own implementation of removeDiacritics. May be it's possible not to use andrewrk/node-diacritics? The probable place is here. |
Good catch, thanks. I've not noticed there was already an implementation of this function in lib |
I've tested 1.5.7 version, and it works well now for newly created notes. But there is steel 'n' for old notes instead of 'Л'. Anybody knows how to update search index? |
The only thing comes to mind is export, delete your DB and start from scratch |
@laurent22 Could you please make it clear, is there another way to update search index except of re-importing all DB? |
If there's only a few notes, you can also manually modify each of them (like add a space) for example, which will retrigger indexing for those notes. |
Environment
Joplin version: 1.3.11
Platform: Linux
OS specifics: Linux Mint 19.3 (based on Ubuntu 18.04)
Steps to reproduce
Create note titled with cirillic symbol "Л"
Press
Ctrl+P
and type some text from titleIn search results you can see that "Л" was replaced with "n"
The text was updated successfully, but these errors were encountered: