Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple variants of the same spellcheck languages in the title bar should be more specific (or merged) #7834

Closed
tomasz1986 opened this issue Feb 24, 2023 · 3 comments · Fixed by #9983
Closed

Multiple variants of the same spellcheck languages in the title bar should be more specific (or merged) #7834

tomasz1986 opened this issue Feb 24, 2023 · 3 comments · Fixed by #9983
Labels
bug It's a bug desktop All desktop platforms medium Medium priority issues

Comments

@tomasz1986
Copy link

Environment

Joplin version: 2.10.4
Platform: all desktop platforms
OS specifics: all desktop OSs

Steps to reproduce

  1. Enable spell check for English, English (Australia), English (Canada), English (United Kingdom), English (United States), etc.
  2. All of the selected English variants are displayed in the title bar multiple times as just en.
    image

Describe what you expected to happen

The current display format isn't very useful (and also unnecessarily takes horizontal space). I can think of two possibilities to "fix" the problem:

  1. Use more specific shorthand variants, e.g. en-AU, en-GB, en-US, etc.
  2. Display only one single en (and do the same for all other languages that have multiple variants).

Logfile
@tomasz1986 tomasz1986 added the bug It's a bug label Feb 24, 2023
@laurent22
Copy link
Owner

Is it something that you need, selecting multiple times the same language?

@tomasz1986
Copy link
Author

tomasz1986 commented Feb 24, 2023 •
edited
Loading

Yeah, personally I do need to use at least both British and American English.

@laurent22 laurent22 added desktop All desktop platforms medium Medium priority issues labels Feb 24, 2023
@HahaBill
Copy link
Contributor

Hi! I am happy to work on this issue. I will update you on my progress and do the PR provided with images and videos.

HahaBill added a commit to HahaBill/joplin-hahabill that referenced this issue Feb 22, 2024
@HahaBill
Desktop: Made the same spellcheck languages more specific in the titl…
b07903c 
…e bar

- Fixed the issue laurent22#7834

- added "spellCheckerMenu.test.ts" to test the changes and the expected behavior: all passed!

- added jest.mock in "jest.setup.js" to mock the Menu from @electron/remote.

-  modified "buildScriptIndexes" to ignore ".test.ts" files so it does not include them in index.ts. That caused some issues with duplicate identifiers and more errors.
@HahaBill HahaBill mentioned this issue Feb 23, 2024
Merged
3 tasks
laurent22 pushed a commit that referenced this issue Feb 26, 2024
@HahaBill
Desktop: Fixes #7834: Merged shorthand variants of spellcheck languag…
64684dc 
…es (#9983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug desktop All desktop platforms medium Medium priority issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop: Fixes #7834: Merged shorthand variants of spellcheck languages HahaBill/joplin-hahabill
4 participants
@laurent22 @PackElend @tomasz1986 @HahaBill