Desktop: Resolves #9980: Support Ctrl+Enter keyboard shortcut (Cmd+Enter on MacOS)

[cagnusmarlsen]

Fixes #9980 by adding key bindings for Ctrl+Enter on Windows/Linux and Cmd+Enter on macOS. This adds functionality to add a new line after the line where the cursor currently is.

Testing

This has been tested successfully on Windows 11 and Ubuntu.

Test.mp4

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[cagnusmarlsen]

I have read the CLA Document and I hereby sign the CLA

[personalizedrefrigerator]

While this fixes the issue in the legacy CodeMirror 5-based markdown editor, the issue is still present in the CodeMirror 6-based editor.

To make this work, I suspect that additional command declarations will have to be added here:

joplin/packages/editor/CodeMirror/editorCommands/editorCommands.ts

Line 15 in 40ae03c

const editorCommands: Record<EditorCommandType, EditorCommandFunction> = {

Alternatively, to also support mobile, the beta editor keyboard shortcuts could be added here:

joplin/packages/editor/CodeMirror/createEditor.ts

Line 263 in 40ae03c

keyCommand('Shift-Tab', decreaseIndent, true),

Thank you for working on this!

[cagnusmarlsen]

Thank you for the help. I've added the necessary shortcut to joplin/packages/editor/CodeMirror/createEditor.ts. Now works for both the editors.

[personalizedrefrigerator]

Consider using insertLineAfter from editorCommands/insertLineAfter.ts here. insertLineAfter should handle list continuation and auto-indentation.

[cagnusmarlsen]

That makes sense. Made the necessary changes.

[cagnusmarlsen]

@PackElend label me please

Link to introduction - https://discourse.joplinapp.org/t/introducing-marlsen/36358