Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipper, Desktop: Prevent race condition when download limit is reached #10124

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Clipper, Desktop: Prevent race condition when download limit is reached #10124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3870fef
request might have been destroyed by download limiter
pedr Mar 14, 2024
3fb765d
add comment about the code
pedr Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/lib/shim-init-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,13 +599,19 @@ function shimInit(options: ShimInitOptions = null) {

try {
await gunzipFile(gzipFilePath, filePath);
// Calling request.destroy() within the downloadController can cause problems.
// The response.pipe(file) will continue even after request.destroy() is called,
// potentially causing the same promise to resolve while the cleanUpOnError
// is removing the file that have been downloaded by this function.
if (request.destroyed) return;
resolve(makeResponse(response));
} catch (error) {
cleanUpOnError(error);
}

await shim.fsDriver().remove(gzipFilePath);
} else {
if (request.destroyed) return;
resolve(makeResponse(response));
}
});
Expand Down
Loading