Desktop: Reduce application size #11505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built AppImage decreases in size from 285.9 MB to 238 MB.
Not bundling the tests doesn't make a significant difference in app size.
Comment on lines
+21
to
+22
|
|
||
| "//": "Mermaid is bundled by buildAssets.js -- using it as an unbundled dependency significantly increases app size.", |
There was a problem hiding this comment.
I'm not sure about leaving comments in package.json with "//" (the suggestion in the upstream npm issue). Perhaps it would be better to document this somewhere else?
There was a problem hiding this comment.
Yes i guess this is good enough. It's indeed tricky to document package.josn because of this limitation on comments
personalizedrefrigerator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is a follow-up to @pedr's work on decreasing the application build size.
This pull request moves
mermaidfrom a runtime dependency to a dev dependency of the renderer package. This decreases the locally-builtAppImagesize from from 285.9 MB to 228.6 MB.At present,
mermaidis bundled into an asset file and only used from this asset file. As such, themermaidpackage innode_modulesis unused at runtime. This is the case on both mobile and desktop.Testing plan
.AppImageusingyarn dist..AppImage.mermaidgraph.gitGraph: