Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: build universal app for macOS X #5537

Closed
wants to merge 2 commits into from

Conversation

runchard
Copy link

@runchard runchard commented Oct 6, 2021

This PR will make the Joplin desktop app running in both intel and M1 chip both natively.

This is an electron feature support from version 11.0.0.

How do I test it?

Currently, Apple Silicon applications only run on Apple Silicon hardware, which isn't commercially available at the time.

PS: I've use it in my silicon version Macbook pro for several days.

reference

@laurent22
Copy link
Owner

The linked article says we'd need to ship two versions of the app, but your change seems to mean you remove the dmg and replaced by something else.

@tessus
Copy link
Collaborator

tessus commented Oct 6, 2021

I do not want a universal binary on macOS. This BS was finally over and now they started again with this crap.

I rather have 2 dmg for the respective architectures.

@laurent22
Copy link
Owner

Yes, perhaps two versions would be fine, but even that I'm not sure. We don't quite have the resources to deal with all the rubbish coming from Apple, from the insane iOS release process, to the idiotic notarisation. That would be adding yet one more way things can fail, so that's why I'm not so keen on it, unless it becomes really necessary.

@tessus
Copy link
Collaborator

tessus commented Oct 6, 2021

Yes, the Apple release pipeline is a joke. Not to mention the deprecation of APIs without proper replacements, the lack of proper runtime/compile messages, .... Apple took the fun out of developing for Apple. That's why I'm no longer writing code for macOS.

@runchard
Copy link
Author

runchard commented Oct 7, 2021

Make sense, separate bundle can make dmg smaller and less prone to complex errors.

@runchard
Copy link
Author

runchard commented Oct 7, 2021

ref config at electron-userland/electron-builder#5426

@laurent22
Copy link
Owner

Ok thanks for looking into it but at that point we probably won't add this. It probably requires more testing on CI and we don't really have the resources for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants