Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the full pi constant as acos(-1.) #66

Merged
merged 1 commit into from
May 11, 2021

Conversation

eldritchconundrum
Copy link
Collaborator

No description provided.

@laurentlb
Copy link
Owner

Do you expect users to put exactly the same number of PI digits as you?

@eldritchconundrum
Copy link
Collaborator Author

Yes. If they don't put as many digits as what fits in a double, it becomes semantically hazardous to replace the number by a different number.

@laurentlb
Copy link
Owner

What if they put more digits?
If that's the maximum precision of float, it should also match right? If that's the case, please add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants