Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sticky-header functionality #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added sticky-header functionality #25

wants to merge 3 commits into from

Conversation

lauriii
Copy link
Owner

@lauriii lauriii commented Dec 11, 2014

No description provided.

@lewisnyman
Copy link
Collaborator

Nice, this is looking good. I had to change the path to the debounce lib to get it to work, there is a bit of a delay when scrolling which is kind of distracting, is there a way to just have it fixed like it is in core?

@lauriii
Copy link
Owner Author

lauriii commented Dec 12, 2014

I think its problem on the debounce library. We could also choose not to use it

@lewisnyman
Copy link
Collaborator

It looks like this library works quite well, if we use this then we have less custom code, what do you think? https://github.com/jmosbech/StickyTableHeaders

@lewisnyman
Copy link
Collaborator

Ooh maybe we can use position: sticky; and then polyfill it with https://github.com/filamentgroup/fixed-sticky? Then we get the best performance

@lewisnyman
Copy link
Collaborator

I tried using the polyfill in https://github.com/lewisnyman/drupalcores/tree/super-sticky-table but it sucked
I also tried using another library in https://github.com/lewisnyman/drupalcores/tree/stikcy-table-headers but there are a few minor problems, because if you use the #contributor link then it gets covered up by the sticky header, we would also need to implement a custom handler for that behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants