Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Fix: address whiteout issue #123

Merged
merged 5 commits into from
Jan 8, 2020

Conversation

TheFern2
Copy link
Contributor

@TheFern2 TheFern2 commented Jan 4, 2020

I am updating the modals to inhibit the create buttons if the text input boxes are not filled in. I also need to update the update note modal. I'll let you know when I am done.

This addresses #119 strangely enough it looks like is only an issue with local notes, and only on windows. I tried to recreate on linux/mac with no luck. Regardless I think the create button shouldn't be enabled until all text input is filled in, if anyone have any other thoughts I am all ears. :)

@lauthieb
Copy link
Owner

lauthieb commented Jan 5, 2020

Thanks! A will review this when the update modal will be OK.
Yes it’s pretty weird, I cannot reproduce too...

@TheFern2
Copy link
Contributor Author

TheFern2 commented Jan 6, 2020

@lauthieb Ok, I think I am done with thie PR and ready for a review.

  • All text input boxes are now required input.
  • Create button will not be enabled until all text boxes are filled in, including content.
  • Required input boxes, have also the required property on the b-input to alert user in the UI.

Tested build on linux and windows.

@lauthieb lauthieb changed the title WIP: To address whiteout issue Fix: address whiteout issue Jan 8, 2020
@lauthieb
Copy link
Owner

lauthieb commented Jan 8, 2020

Thank you @kodaman2, I've just made a PR on your branch here TheFern2#2 to simplify the code.

Copy link
Owner

@lauthieb lauthieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check TheFern2#2 to simplify your code :)

@TheFern2
Copy link
Contributor Author

TheFern2 commented Jan 8, 2020

Please check kodaman2#2 to simplify your code :)

Love the simplication! Merged :)

@lauthieb lauthieb merged commit d546446 into lauthieb:master Jan 8, 2020
@lauthieb
Copy link
Owner

lauthieb commented Jan 8, 2020

Thanks! Merged :)
We will make a new version pretty soon.

@lauthieb
Copy link
Owner

lauthieb commented Jan 8, 2020

Closes #119

@lauthieb lauthieb mentioned this pull request Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants