This repository was archived by the owner on Sep 13, 2023. It is now read-only.
fix(bug): Issue with periods in filenames #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes lauthieb#59 Resolves issue with disallowed nedb characters. Noticed that this was broken on update as well, so created a method in `converter` to convert a file into a nedb-compatible key. This ballooned a bit more than I expected. Hopefully everything fits convention - please let me know if there's something I need to change.
|
Hello @aspencer, thanks a lot! |
|
Released in 1.2.2! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Resolves issue with disallowed nedb characters. Noticed that this was broken on update as well, so created a method in
converterto convert a file into a nedb-compatible key.This ballooned a bit more than I expected. Hopefully everything fits convention - please let me know if there's something I need to change.