-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3 #135
Merged
Merged
Release v3 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # LavalinkClient/src/main/java/lavalink/client/io/Lavalink.java # LavalinkClient/src/main/java/lavalink/client/io/LavalinkLoadBalancer.java # LavalinkClient/src/main/java/lavalink/client/io/Link.java
* Add isPlaylist to response JSON * Unmodifiable list * Expose selectedTrack and playlistName
This resolves an issue regarding WAV formats that have excess bytes
* add lavaclient to list of libs which support v3 * testing lavalink version header * change Lavalink-Version to Lavalink-Major-Version * update implementation file to make ppl aware of the change * significant over breaking, removal of non breaking
* Fix missing documentation for playlistInfo * Update IMPLEMENTATION.md
# Conflicts: # LavalinkClient/build.gradle # LavalinkServer/build.gradle # README.md
* add result status enum * move load result out into its own class * load changes * add search result value + logic for it * document load types * removed isPlaylist field from docs * add checks for unknown value * remove isPlaylist field * clarify version changes * add references to pr's
As pylava doesn't touch /loadtracks output, it should be fully compatible with Lavalink 3.x
Excuse me v3 coming through
freyacodes
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎊
freyacodes
added a commit
to freyacoded/repo-test
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.