[v1-legacy] Fix one instance of invalid OGG Opus duration extraction #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the retrieved
sampleRatevalue was an arbitrary number, not indicative of the actual sample rate. This lead to invalid duration values.This seems to be caused by an error in the
firstPacketbuffer contents after reading comments and tags, so it's read before any of that occurs.This has been tested and appears to work correctly, yielding the correct value of
48000in my test files.This commit has also been tested and is inline with the ID header specification found at https://wiki.xiph.org/OggOpus#ID_Header