Fix NicoNico Track

[a9lim]

NicoNico removed their getflv API sometime this march. I implemented this blog post's solution and referenced this library's JSON repackaging.

[devoxin]

I have many points to raise about this PR.

1. Is an account necessary to stream tracks?
   1b. If it is, why is this source manager initialised with default values of null if it's unusable?
2. It is advisable to use a ScheduledExecutor over a Timer.
3. Parsed JSON responses should really be using the library-provided JsonBrowser class as it's a little more resilient to unexpected response changes.
4. A lot of lines need breaking up into separate statements, for example, request.setEntity(new StringEntity(processJSON(loadVideoMainPage(httpInterface)).toString()));.
   4b. The monolithic function processJSON should also be split up into several lines rather than trying to create a JSONObject inside a JSONObject inside a JSONObject inside a ...
5. If the sendHeartbeat function is detrimental to being able to stream a track, it should not be handled gracefully but instead stop the processing of the track as it would be unrecoverable.

[a9lim]

Thank you so much for the fast response and feedback, so sorry about the issues with the code. I'm self-taught and first made the changes while modifying a music bot so I'm not too familiar with standard practice. I'll rewrite to to align with the feedback.

An account is not necessary to stream most tracks, and I haven't found a track that needs an account to access it. However, the niconico.py library still has a login feature, so I left it in as a precaution in case there's some scenario where it's needed.

[topi314]

There is no need to close this, you can simply push additional commits to this pr
We will squash this anyway

[a9lim]

Thank you, this is my first pull request so I don't really know how stuff on that front works either. For point 4b, is there a recommended way on how I should be splitting up the JSON creation? Naively, I want to do something like

, but this feels like it still has the same issue. Thank you so much for your patience!

[a9lim]

Tried using JsonBrowser as an alternative but am not sure if this is what the syntax should be looking like, let me know if this is acceptable:

Additionally, I'm a college student so I may be busy, but I will try to get this resolved as quickly as possible.

[a9lim]

I've tried to implement the changes as advised, still unsure about processJSON but let me know what else I could do.

[JellyBrick]

additional note: It resolves Walkyst/lavaplayer-fork#85

[topi314]

please reformat your codestyle to match the rest of the codebase

[devoxin]

I've tried to implement the changes as advised, still unsure about processJSON but let me know what else I could do.

You're on the right track with it but still looks extremely bulky. Is every field there really necessary for playback?

[a9lim]

Seems like almost every field is necessary, I've tried to remove each of them in testing but only content_uri and priority can be omitted without the request 400'ing. I'll also join the discord, might be more convenient to discuss changes I should make there.

[a9lim]

Moving discussion to https://discord.com/channels/1082302532421943407/1183572413213053038

[topi314]

can you also make getWatchUrl return a https link?

[devoxin]

Done.

[topi314]

should prob be fine now