Fix inspector on nodejs v20

Fixes #433
laverdet · Jan 11, 2024 · 7f70d25 · 7f70d25
1 parent 266d9e8
commit 7f70d25
Show file tree

Hide file tree

Showing 4 changed files with 405 additions and 2 deletions.
diff --git a/inspector-example.js b/inspector-example.js
@@ -50,4 +50,4 @@ wss.on('connection', function(ws) {
 	channel.onResponse = (callId, message) => send(message);
 	channel.onNotification = send;
 });
-console.log('Inspector: chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=127.0.0.1:10000');
+console.log('Inspector: devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=127.0.0.1:10000');
diff --git a/src/isolate/inspector.cc b/src/isolate/inspector.cc
@@ -79,7 +79,11 @@ void InspectorAgent::quitMessageLoopOnPause() {
  */
 auto InspectorAgent::ConnectSession(InspectorSession& session) -> unique_ptr<V8InspectorSession> {
 	active_sessions.write()->insert(&session);
+#if V8_AT_LEAST(10, 3, 118)
+	return inspector->connect(1, &session, StringView(), v8_inspector::V8Inspector::ClientTrustLevel::kFullyTrusted);
+#elif
 	return inspector->connect(1, &session, StringView());
+#endif
 }
 
 /**

diff --git a/src/isolate/v8_inspector_wrapper.h b/src/isolate/v8_inspector_wrapper.h
@@ -1,7 +1,9 @@
 #pragma once
 #include "node_wrapper.h"
 #include "./v8_version.h"
-#if V8_AT_LEAST(10, 2, 154)
+#if V8_AT_LEAST(11, 3, 244)
+#include "v8_inspector/nodejs_v20.0.0.h"
+#elif V8_AT_LEAST(10, 2, 154)
 #include "v8_inspector/nodejs_v18.3.0.h"
 #elif V8_AT_LEAST(10, 1, 124)
 #include "v8_inspector/nodejs_v18.0.0.h"