Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running on Node 20.11 #441

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix running on Node 20.11 #441

merged 1 commit into from
Jan 16, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jan 16, 2024

CompileFunctionInContext was removed.

See nodejs/node-v8#214.

Fixes #436.

@laverdet
Copy link
Owner

Can you wrap this in a V8_AT_LEAST(10, 1, 1) with the old invocation in the else case please

CompileFunctionInContext was removed.

See nodejs/node-v8#214.

Fixes laverdet#436.
@orgads
Copy link
Contributor Author

orgads commented Jan 16, 2024

Can you wrap this in a V8_AT_LEAST(10, 1, 1) with the old invocation in the else case please

Done (more or less :))

@laverdet
Copy link
Owner

Lmao what a mad man

@laverdet laverdet merged commit 90a4746 into laverdet:main Jan 16, 2024
8 of 12 checks passed
@orgads orgads deleted the node-20.11 branch January 16, 2024 19:38
@webark
Copy link

webark commented Jan 18, 2024

is 4.7.0 planning on getting released to NPM? Or is there some other process that needs to be completed first for that to happen.

@moonrailgun
Copy link

I found this pr from #436 and i just wanna know whats this pr release plan? i think my work is broken because i wanna support arm64 but i cannot direct use debian:bookworm which this issue taking about(old docker services not support)

@orgads
Copy link
Contributor Author

orgads commented Jan 19, 2024

@laverdet Can you please merge my other PRs, then publish a new version to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange symbol not found error on docker image node:20.11.0-alpine
4 participants