Restore an *actual* async resource, not just the ID #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znewsham
commented
Nov 4, 2022
| @@ -30,6 +30,7 @@ function setupAsyncHacks(Fiber) { | |||
| // Older (or newer?) versions of node may not support this API | |||
| try { | |||
| var aw = process.binding('async_wrap'); | |||
| var ah = require('async_hooks'); | |||
There was a problem hiding this comment.
for some reason my editor hates tabs :(
|
I love gnarly hacks. This change definitely looks more promising than the other PR. I'm not cutting more releases at this time but I'll make sure to take a note of the change in case anyone else runs into the same issues. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the project is dying, feel free to ignore this PR (I need it for my work on
AsyncResourcesand it seems generally relevant)The existing save/restore stack looses the reference to the actual
AsyncResource- if you try to use (for example)AsyncLocalStorage- it will fail because the current asyncResource is undefined (even though the ID is).This PR adds one more gnarly hack to these functions - to grab the existing
AsyncResourcethen manually push it back onto the stack.I modified the async_hooks test to check for this too. All the tests that were passing before are passing now (for some reason pool and cleanup fail for me on master).