Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue merge the implemented --entrypoint and --rm #124

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

ydf
Copy link

@ydf ydf commented Jan 6, 2025

RT

@lavie
Copy link
Owner

lavie commented Jan 10, 2025

Could you please add an assertion to make sure that we do not emit --entrypoint in case the default entrypoint has not been changed?

Something like self.dont_expect_substr("--entrypoint /bin/bash", 1)

@lavie lavie enabled auto-merge January 10, 2025 16:16
@lavie lavie merged commit b8d376b into lavie:master Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants