#1: Update chips_sold plot #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snairdesai
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Thanks @lawrencech3n! This looks good to merge, thanks for the work. You'll want to "squash and merge" using the green dropdown below, and then in the issue associated with the PR (#1), add a summary comment where you add a link to the stable state of the branch and a stable link of the merge commit. You can look at ~/gentzkow/template for an example.
lawrencech3n
added a commit
that referenced
this pull request
Oct 27, 2023
commit 97fa1eb Author: Lawrence Chen <146892035+lawrencech3n@users.noreply.github.com> Date: Thu Oct 26 14:16:34 2023 -0700 #1: Update chips_sold plot (#3) Co-authored-by: Lawrence Chen <lawrencechen@DN0a23334b.SUNet> The goal of the issue is to modify the code in the data folder ([`~/data/code/clean_data.py`](https://github.com/lawrencech3n/gentzkow/blob/master/data/code/clean_data.py)) so that the histogram in [`~/paper_slides/output/chips_sold.pdf`](https://github.com/lawrencech3n/gentzkow/blob/fe13790124dbe08001d6a88cbc0be28ff72567fc/paper_slides/output/paper.pdf) displays percentages instead of counts. This follows from the [Practice Task Instructions](https://github.com/gslab-econ/lab-manual/wiki/Practice-Task).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the pull request is to modify the code in the data folder (
~/data/code/clean_data.py) so that the histogram in~/paper_slides/output/chips_sold.pdfdisplays percentages instead of counts. This follows from the Practice Task Instructions.