Control initial expanded state of TOC; support URLs for items #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will make the peachjam taxonomy trees collapsed by default, which is much easier to navigate for complex trees. |
goose-life
reviewed
May 4, 2023
| @@ -78,6 +78,7 @@ export class TocItem { | |||
| render() { | |||
| const isParent = !!this.item.children?.length; | |||
| const showItem = !this.filteredItems || this.filteredItems.has(this.item); | |||
| const url = this.item.url || `#${this.item.id || ''}`; | |||
There was a problem hiding this comment.
should the `#${ before this.item.id come out?
There was a problem hiding this comment.
The old mechanism for determining the URL for a TOC item was to use the id attribute to create a link like #chp_2. We're now adding support for an optional url attribute, and falling back to the old ID if it's not there. The #${...}\ is a javascript interpolation string equivalent to f'#{...}' in python. The # is literally just that, and the $ indicates the interpolation inside the curlies.
There was a problem hiding this comment.
oh my bad, I missed the closing } 🤦
goose-life
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means the TOC can be collapsed when first rendered, and it makes it much easier to associate arbitrary URLs with a TOC item