Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lightbox: Escape key support & Image size optimization #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zihanKuang
Copy link

Description
This PR introduces two improvements to the documentation:

  1. Lightbox Enhancement: Adds support for closing the modal when the Escape key is pressed.
  2. Image Display Optimization: Ensures that both Markdown images and <img> elements are properly scaled to avoid overly large displays by default.

This improves user experience by preventing images from taking up excessive space and making the Lightbox more user-friendly.

Notes for Reviewers

  • My local environment displays images correctly, but the official site shows different images, even though the paths are identical.
  • Could this be a CDN caching issue, or is there another caching layer affecting images?
  • Does the site apply any automatic image processing that might alter them?

Any insights would be greatly appreciated. Thank you! 😊

  • Yes, I signed my commits.
1741740998865 1741741030580

Signed-off-by: Zihan Kuang <zihan_kuang@outlook.com>
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit dfd475c
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67d0ddd29af7f30008180f14
😎 Deploy Preview https://deploy-preview-454--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant