Added Member Profile. #2208
Added Member Profile. #2208
Conversation
Added zainuddeen-abdul-muiz 's member profile, contributing to issue layer5io#2205
Signed-off-by: Sandeep Rajakrishnan <sandur43@gmail.com>
san-coding
force-pushed
the
san-coding
branch
from
e181ae6
to
0517251
Compare
|
Any chance you could signoff this commit? https://github.com/layer5io/layer5/pull/2208/checks?check_run_id=3662225688 |
Yes I will do it in sometime |
|
🚀 Preview for commit 0517251 at: https://6149bcc287f488c0728b8f96--layer5ng.netlify.app |
Signed-off-by: Sandeep Rajakrishnan <sandur43@gmail.com>
|
I have actually signed off both commits now, I reverted both commits, then made the commits and signed them |
|
Umm, still doesn't seem to be signed-off. |
|
Is there a way to sign off commits through GitHub UI |
|
No, not really, I'll give you a free-pass on this one, considering you've had a long day figuring out how to setup locally. Also, I'm pretty sure @Zain-Muiz os quite excited for his profile😄. Please try to take care from next time. https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md ( some resources) |
|
🚀 Preview for commit 68e3e9f at: https://6149cb79dfad5412b03723ed--layer5ng.netlify.app |
|
@Zain-Muiz this is your profile. Let's make sure that you get a chance to review and approve before publishing. |
|
@leecalcote he gave me a LGTM on slack, that's why i went ahead with the merge. |
|
When did the DCO test pass, lol I am still working on it |
Yeah thanks a lot, have been tackling several errors one by one from the morning🤣, but I know what the problem was with the signing-off, I forgot sign off first commit, but signed the second one |
|
@san-coding i made it to pass😅. |
I enabled auto signoff on vscode after the first commit, which resulted in the second commit getting signed off but not the first one 😓 |
|
Aah okay, just something to keep in mind from next time I guess😅 |
Yeah it is enabled now on vscode, won't be a problem for any commit in the future, thanks @warunicorn19 |
|
what happens when one of the commits is not signed off ? will it have any effect (but the latest commit is signed off) |
|
well, all your commits should be signed off, but if the latter commit is signed off while the former is not, that shouldn't be an issue, the DCO should pass for that, your latest commit is the one that needs to pass the DCO. |
|
Ohh ok, do tag me in issues that you think I could work on, thanks |
|
some |
Sure, looking forward to contributing to layer5, won't bug you so much next time😅 , thanks @warunicorn19 @Zain-Muiz |
|
No problem @san-coding😄 |
Can someone explain how this works, how is it giving a preview for each commit, how to set this up |
|
@san-coding, there's no need to setup anything here. Each time an update is made a new site preview is built. There are a number of ways to configure such automation. The automation here is all configured and running on-task. ✔️ |
|
@leecalcote I want to add this to my repo, how can I set up this automation, what is it called |
|
This is a really useful automation, I didn't know about it before contributing to layer 5, want to set it up on this repo : https://github.com/sudhay23/ShopOnline-Web-App |
|
GitHub Actions. |
|
Which action is it ? I am unable to find build preview action |
|
https://github.com/marketplace?type=&verification=&query=netlify+preview+, these might help, you'd have to have a netlify account. The easier way would be to just get a netilfy account and set up a netlify bot on your repo, it'll auto-build on each commit on every PR. |
|
Please see https://discuss.layer5.io for further discussion. |
Description
This PR fixes #2205
Added community member profile for @Zain-Muiz
Notes for Reviewers
Signed commits