Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Images in Cloudevents How it Works See in Action Section #5437

Closed
wants to merge 2 commits into from

Conversation

Chay2203
Copy link
Contributor

@Chay2203 Chay2203 commented Mar 3, 2024

Description

This PR fixes #4869

Notes for Reviewers
I have updated the images in the "How it Works See in Action" Section, please have a look at it ;D

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Mar 3, 2024

🚀 Preview for commit 0a9b03a at: https://65e4bda742cf7ebbce1f9651--layer5.netlify.app

@vishalvivekm
Copy link
Member

@Chay2203 Let's discuss this on Websites's call today 6:30 PM IST. Let's add this as an agenda item into the meeting minutes

Signed-off-by: Naga Chaitanya Varma <69190057+Chay2203@users.noreply.github.com>
@Chay2203
Copy link
Contributor Author

Chay2203 commented Mar 6, 2024

Hey @vishalvivekm, I have made the necessary changes that we discussed in the GMeet, please have a look now :)

@l5io
Copy link
Contributor

l5io commented Mar 6, 2024

🚀 Preview for commit 9bdae94 at: https://65e8b48b060ab9355b3879d0--layer5.netlify.app

@iArchitSharma
Copy link
Contributor

@Chay2203 images should only be present in the src/collections/integrations/_images/cloudevents/ directory, remove them from other places

Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the above

@Chay2203
Copy link
Contributor Author

Chay2203 commented Apr 4, 2024

Sure will do it @iArchitSharma

@iArchitSharma
Copy link
Contributor

@Chay2203 still working on it?

@Chay2203
Copy link
Contributor Author

busy with other things @iArchitSharma, please assign it to someone else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Screenshots] Cloudevents under 'How it Works See It in Action' section
5 participants