Add Instructions for how to refer to your local Sistent fork #1012
Conversation
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
|
shouldn't be first to build the sistent before u install sistent into project to reflect the changes u made? @M-DEV-1 build sistent -> install the changed package -> npm install |
|
@vr-varad you're right, but i think, since the user keeps making changes and builds both the repositories to track them, each time the latest version is referenced. |
|
@alokdangre, would you like to offer review here? |
|
@FaheemOnHub isn't going to respond, so @amitamrutiya, if this PR's instructions are accurate, please merge. |
leecalcote
requested review from
amitamrutiya and
vr-varad
and removed request for
FaheemOnHub and
falgunmpatel
| make ui-build | ||
| ``` | ||
| Now your project should reflect changes from your local Sistent fork. |
There was a problem hiding this comment.
Where are the instructions for reversing the change?
Co-authored-by: Lee Calcote <leecalcote@gmail.com> Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
ok , I would love to review it @leecalcote |
|
@M-DEV-1 Added as an agenda item to the meeting minutes |
| If you want to remove the local Sistent fork from your project, run: | ||
| ``` | ||
| npm uninstall @layer5/sistent | ||
| ``` | ||
There was a problem hiding this comment.
have you test this uninstall is working or not? @M-DEV-1
There was a problem hiding this comment.
yes, this command works and removes the installation of the local sistent fork.
6 participants
Notes for Reviewers
This PR fixes #1008
Signed commits