Removed fillOpacity from CrossCircleIcon #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Rajesh-Nagarajan-11 any screen shot of changes before and after |
Member
Author
|
its just remove the default opacity that's it @saurabhraghuvanshii |
Member
Author
|
Before : 
After : 
|
saurabhraghuvanshii
requested changes
Jan 6, 2026
src/icons/CrossCircle/index.tsx
Outdated
| <path d="M0 0h24v24H0z" fill={props.stroke || '#FFFFF'} /> | ||
| </clipPath> | ||
| </defs> | ||
| <path d="M12 2C6.47 2 2 6.47 2 12s4.47 10 10 10 10-4.47 10-10S17.53 2 12 2m5 13.59L15.59 17 12 13.41 8.41 17 7 15.59 10.59 12 7 8.41 8.41 7 12 10.59 15.59 7 17 8.41 13.41 12z" |
Member
There was a problem hiding this comment.
@Rajesh-Nagarajan-11 keep path same as previous just remove fill
Member
Author
There was a problem hiding this comment.
I just use the official path used from mui
Member
There was a problem hiding this comment.
@Rajesh-Nagarajan-11 if you compare both icons some shape changes you will notice which is not required, only requirement is to remove default color
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
saurabhraghuvanshii
approved these changes
Jan 6, 2026
Member
|
Thanks @Rajesh-Nagarajan-11 lgtm!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR removes the Default -> fillOpacity property from the CrossCircleIcon.
Signed commits