Skip to content

Fix: Prevent unexpected card flip when non-owner users click workspace action buttons #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rajesh-Nagarajan-11 wants to merge 1 commit into from
Closed

Fix: Prevent unexpected card flip when non-owner users click workspace action buttons #1197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions src/custom/Workspaces/WorkspaceCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,11 +354,12 @@ const CardBack = ({
<CardBackWrapper elevation={2} onClick={onFlipBack}>
<CardBackTopGrid size={12}>
<CardBackTitleGrid size={6}>
<BulkSelectCheckbox
onClick={(e) => e.stopPropagation()}
onChange={onSelect}
disabled={deleted ? true : !isDeleteWorkspaceAllowed}
/>
<div onClick={(e) => e.stopPropagation()}>
<BulkSelectCheckbox
onChange={onSelect}
disabled={deleted ? true : !isDeleteWorkspaceAllowed}
/>
</div>
<CardTitle
sx={{ color: theme.palette.background.constant?.white }}
variant="body2"
Expand All @@ -368,18 +369,22 @@ const CardBack = ({
</CardTitle>
</CardBackTitleGrid>
<CardBackActionsGrid size={6}>
<L5EditIcon
onClick={onEdit}
disabled={isEditButtonDisabled}
style={{ fill: theme.palette.background.constant?.white }}
bulk={true}
/>
<L5DeleteIcon
onClick={onDelete}
style={{ fill: theme.palette.background.constant?.white }}
disabled={isDeleteButtonDisabled}
bulk={true}
/>
<div onClick={(e) => e.stopPropagation()}>
<L5EditIcon
onClick={onEdit}
disabled={isEditButtonDisabled}
style={!isEditButtonDisabled ? { fill: theme.palette.background.constant?.white } : undefined}
bulk={true}
/>
</div>
<div onClick={(e) => e.stopPropagation()}>
<L5DeleteIcon
onClick={onDelete}
style={!isDeleteButtonDisabled ? { fill: theme.palette.background.constant?.white } : undefined}
disabled={isDeleteButtonDisabled}
bulk={true}
/>
</div>
</CardBackActionsGrid>
</CardBackTopGrid>
<Grid2 sx={{ display: 'flex', alignItems: 'center', flexDirection: 'row' }}>
Expand Down