Skip to content

Add fill Prop Support to GithubIcon #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leecalcote merged 3 commits into from
Jan 6, 2026
Merged

Add fill Prop Support to GithubIcon #1198

leecalcote merged 3 commits into from
Jan 6, 2026

Conversation

@Rajesh-Nagarajan-11
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 commented Jan 6, 2026

Notes for Reviewers

  • Added a fill prop to the GithubIcon component.
  • Now the icon color can be customized via the fill prop
Screenshot from 2026-01-06 20-24-04
  • Corrected the viewBox coordinates because, even though the icon is 24×24, it appeared smaller compared to others. Updating the viewBox ensures consistent sizing across all icons.

Before :
Screenshot from 2026-01-06 20-39-53
After :
Screenshot from 2026-01-06 20-41-41

Signed commits

  • Yes, I signed my commits.

Rajesh-Nagarajan-11 and others added 3 commits January 6, 2026 20:19
@Rajesh-Nagarajan-11
added fill props
8d23972 
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
@Rajesh-Nagarajan-11
hanged the viewBox attribute improve visual appearance and alignment.
4274a91 
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
@Rajesh-Nagarajan-11
Merge branch 'layer5io:master' into fill-prop-icon
546c79a
@leecalcote leecalcote merged commit 64dc441 into layer5io:master Jan 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rajesh-Nagarajan-11 @leecalcote