Add vertical, horizontal #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucdion
reviewed
Oct 7, 2019
Sources/FlexLayout.swift
Outdated
| This method is valid only when the item position is absolute (`view.flex.position(.absolute)`) | ||
| */ | ||
| @discardableResult | ||
| public func horizontalDirected(_ value: CGFloat) -> Flex { |
There was a problem hiding this comment.
Not sure that horizontalDirected is required since we set start and end to the same value, this is equivalent to setting the left and right.
There was a problem hiding this comment.
Yeap, you are right, miss this moment. Will remove horizontalDirected
lucdion
reviewed
Oct 7, 2019
Sources/FlexLayout.swift
Outdated
| This method is valid only when the item position is absolute (`view.flex.position(.absolute)`) | ||
| */ | ||
| @discardableResult | ||
| public func horizontal(_ value: CGFloat) -> Flex { |
There was a problem hiding this comment.
Good, could you please add theses methods in the documentation (README.md) in the section https://github.com/layoutBox/FlexLayout#4-absolute-positioning.
|
I can also add |
lucdion
changed the title
|
New release including your change https://github.com/layoutBox/FlexLayout/releases/tag/1.3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vertical, horizontal and horizontalDirected to absolute positioning. Useful methods instead of .top(x).bottom(x), start(y).end(y), etc. (Just like in pin)