Add baseline item support! #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucdion
approved these changes
May 27, 2020
|
Any idea why Travis-CI didn't report the status @rantingmong? |
|
That I am not aware of, maybe because I'm pull requesting from a fork I made? Or the branch is not master? |
|
One last thing that I missed @rantingmong , it would be great if you could update this section of the documentation https://github.com/layoutBox/FlexLayout#alignitems. Don't bother with the image if you want. Thanks! |
|
Sure! |
OhKanghoon
added a commit
to OhKanghoon/FlexLayout
that referenced
this pull request
Sep 23, 2023
OhKanghoon
added a commit
to OhKanghoon/FlexLayout
that referenced
this pull request
Sep 23, 2023
OhKanghoon
added a commit
to OhKanghoon/FlexLayout
that referenced
this pull request
Sep 23, 2023
OhKanghoon
added a commit
to OhKanghoon/FlexLayout
that referenced
this pull request
Sep 23, 2023
OhKanghoon
added a commit
to OhKanghoon/FlexLayout
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
baselinealignItemsupport forUILabel,UITextField, andUITextView.For now baseline support is only for the first baseline. Last baseline needs a change into Yoga itself.
Modifications are mostly in YogaKit's YGLayout.