Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error that occur when creating XCFramework #244

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Fix error that occur when creating XCFramework #244

merged 7 commits into from
Feb 12, 2024

Conversation

OhKanghoon
Copy link
Contributor

@OhKanghoon OhKanghoon commented Feb 12, 2024 •
edited
Loading

Background

  • Public header issue occurs when using Objective-C package in Tuist's Dependency. To resolve this issue, I want to provide xcframework.
  • Resolve the issue that occurs when creating xcframework due to duplicate 'postfix operator %'.

Contents

  • remove unnecessary files and headers
    • Modified to manage yoga directly in FlexLayout. Buck dependency is now unnecessary.
  • remove duplicated postfix operator
  • update Podfile.lock
  • remove Info.plist
  • move FlexLayout.h to public header directory

@OhKanghoon OhKanghoon force-pushed the xcframework-build-error branch from fe8c720 to e2c0c62 Compare February 12, 2024 06:54
@OhKanghoon OhKanghoon changed the title Fix error that occur when creating FlexLayout XCFramework Fix error that occur when creating XCFramework Feb 12, 2024
@OhKanghoon
Copy link
Contributor Author

Hi @lucdion
I resolve issues that arise when creating xcframework, and clean up the project's unnecessary setup.
Please review this PR. 😄

lucdion
lucdion approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks 👍

@lucdion lucdion merged commit 8ed7f49 into layoutBox:master Feb 12, 2024
1 check passed
@OhKanghoon OhKanghoon deleted the xcframework-build-error branch February 13, 2024 12:58
@OhKanghoon
Copy link
Contributor Author

Nice cleanup. Thanks 👍

@lucdion
Thanks for review.
I need to fix the xcframework issue, so can I ask you for a new version release?

@lucdion
Copy link
Member

lucdion commented Feb 14, 2024

Sorry, I forgot to do it. 2.0.06 is now available. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucdion lucdion lucdion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OhKanghoon @lucdion