Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrates Yoga sources into FlexLayout #61

Merged
merged 8 commits into from
Feb 23, 2018
Merged

Integrates Yoga sources into FlexLayout #61

merged 8 commits into from
Feb 23, 2018

Conversation

lucdion
Copy link
Member

@lucdion lucdion commented Feb 23, 2018

Finally Yoga's source code has been integrated into FlexLayout 😞

This was not my first choice, but Yoga's repository is diverging from our iOS needs.

Reasons:

  • Yoga is now C++ and not C anymore. This was causing issues when built into frameworks.
  • FlexLayout Carthage support was not really great using Yoga's repository. The previous solution was already using a fork of Yoga's repo, but there was some issues while deploying app to the App store.
  • Some FlexLayout's users wanted to fix some issues into Yoga, but it looks like iOS support is not really a big issue for Yoga.

@lucdion lucdion merged commit 7c620ad into master Feb 23, 2018
@lucdion lucdion deleted the integrates_yoga_sources branch February 23, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucdion