Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update yoga core to latest master #62

Merged
merged 10 commits into from
Feb 27, 2018
Merged

Conversation

zintus
Copy link
Collaborator

@zintus zintus commented Feb 27, 2018

In this PR:

  • Yoga core updated to facebook/yoga@295d111
  • Yoga core tests and their buck configuration added, see core-tests folder
  • FlexLayout.xcodeproj is updated with new core files
  • FlexLayout.podspec updated to include new core
  • Add buck tests to CI config
  • Fix swiftlint errors & warnings
  • Verify that pixel grid rounding issues are gone. See zintus/yoga@ec22448
  • Update carthage

Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

#]

# Should match yoga_defs.bzl + BUCK configuration
spec.compiler_flags = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My issue with .cpp file was due to spec compiler flags 😞

@lucdion
Copy link
Member

lucdion commented Feb 27, 2018

@zintus I have fix fastlane unit tests in the master branch.

@lucdion lucdion merged commit 7b9e498 into layoutBox:master Feb 27, 2018
@lucdion
Copy link
Member

lucdion commented Feb 27, 2018

@zintus
Copy link
Collaborator Author

zintus commented Feb 28, 2018

🚀🚀

@zintus zintus deleted the yoga-core branch February 28, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants