Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounding behaviour #63

Merged
merged 5 commits into from
Feb 28, 2018
Merged

Rounding behaviour #63

merged 5 commits into from
Feb 28, 2018

Conversation

zintus
Copy link
Collaborator

@zintus zintus commented Feb 28, 2018 •
edited
Loading

This PR fixes number of rounding issues:

  • Integer truncation of sizes calculated by sizeThatFits:, and utility functions. Introduced by Obj-C -> Obj-C++ conversion in previous PR
  • Low coordinate rounding threshold, which results in flooring apparently valid values. Layout becomes very wrong with absolute coordinate values larger than 100 and having pointScaleFactor set to 3.

lucdion
lucdion approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@lucdion lucdion merged commit d866b67 into layoutBox:master Feb 28, 2018
@lucdion
Copy link
Member

lucdion commented Feb 28, 2018

Released https://github.com/layoutBox/FlexLayout/releases/tag/1.3.3

@zintus zintus mentioned this pull request Feb 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucdion lucdion lucdion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zintus @lucdion