Fix retain cycle #64
Merged
Fix retain cycle #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucdion
reviewed
Mar 2, 2018
Sources/FlexLayout.swift
Outdated
| @@ -31,7 +31,7 @@ public final class Flex { | |||
| /** | |||
| Flex items's UIView. | |||
| */ | |||
| public let view: UIView | |||
| private weak var view: UIView? | |||
There was a problem hiding this comment.
We could just keep the setter private:
private (set) weak var view: UIView?
This way we could still access it as a weak reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes:
Now
viewofFlexis hidden, because it's a weak variable, and users ofFlexmay brake this state. I think in practice it's rare to seeFlexbeing cached far away from it's hosting view, so this shouldn't be a problem.Now
Flexdon't hold strong reference to it's hosting view, as this introduce retain cycle.