Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support display #87

Merged
merged 3 commits into from
May 10, 2018
Merged

support display #87

merged 3 commits into from
May 10, 2018

Conversation

EkkoG
Copy link
Contributor

@EkkoG EkkoG commented May 4, 2018

I see Flexlayout have no support for Yoga display, and I have added display support, please review the code

Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add this new property to the Readme.md file? Add it next to the isIncludedInLayout property (https://github.com/layoutBox/FlexLayout#isincludedinlayout)

@EkkoG
Copy link
Contributor Author

EkkoG commented May 5, 2018

I have updated the README.md file about display property, sorry for my poor English...

@EkkoG
Copy link
Contributor Author

EkkoG commented May 6, 2018

Travis failed because of brew update timeout

@lucdion lucdion merged commit dc47aa9 into layoutBox:master May 10, 2018
@lucdion
Copy link
Member

lucdion commented May 10, 2018

@cielpy I have published a new release including your change: https://github.com/layoutBox/FlexLayout/releases/tag/1.3.8
Thanks for contributing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants