Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Objective-C API to chained call #229

Merged
merged 9 commits into from
May 18, 2021
Merged

Change Objective-C API to chained call #229

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1f06fe3
update PinLayoutObjC
protosse May 13, 2021
80d7fd1
the layout function will make the code-completion invalid
protosse May 14, 2021
60b59ef
fix macOS build error
protosse May 15, 2021
07be46d
update objective_c.md
protosse May 15, 2021
a4dcf31
update ObjectiveCSpec.m
protosse May 18, 2021
47158a3
update TestObjectiveC.m
protosse May 18, 2021
34397d3
fix TestObjectiveC.m aspectRatio
protosse May 18, 2021
e5eb722
comment TestObjectiveC.m in PinLayout-Carthage-iOS
protosse May 18, 2021
8c77a73
Merge branch 'layoutBox:master' into master
protosse May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions Example/PinLayoutSample/UI/Examples/IntroObjectiveC/IntroObjectiveCView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,30 @@ - (void) layoutSubviews {
CGFloat margin = 10;
UIEdgeInsets safeArea = self.pinObjc.safeArea;

[[[[[[logo.pinObjc topWithInsets:safeArea] leftWithInsets:safeArea] width:100] aspectRatio] margin:margin] layout];
[[[[segmented.pinObjc rightOf:logo aligned:VerticalAlignTop] rightWithInsets:safeArea] marginHorizontal:margin] layout];
[[[[[[textLabel.pinObjc belowOf:segmented aligned:HorizontalAlignLeft] widthOf:segmented] pinEdges] marginTop:margin] sizeToFit:FitWidth] layout];
[[[[[separatorView.pinObjc belowOfViews:@[logo, textLabel] aligned:HorizontalAlignLeft] rightTo:segmented.edge.right] height:1] marginTop:margin] layout];
// [[[[[[logo.pinObjc topWithInsets:safeArea] leftWithInsets:safeArea] width:100] aspectRatio] margin:margin] layout];
// [[[[segmented.pinObjc rightOf:logo aligned:VerticalAlignTop] rightWithInsets:safeArea] marginHorizontal:margin] layout];
// [[[[[[textLabel.pinObjc belowOf:segmented aligned:HorizontalAlignLeft] widthOf:segmented] pinEdges] marginTop:margin] sizeToFit:FitWidth] layout];
// [[[[[separatorView.pinObjc belowOfViews:@[logo, textLabel] aligned:HorizontalAlignLeft] rightTo:segmented.edge.right] height:1] marginTop:margin] layout];
logo.pinObjc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put this on a single line, so that it matches Swift style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK👌

.topInsets(safeArea)
.leftInsets(safeArea)
.width(100).aspectRatio()
.margin(margin).layout();
segmented.pinObjc
.rightOfAligned(logo, VerticalAlignTop)
.rightInsets(safeArea)
.marginHorizontal(margin).layout();
textLabel.pinObjc
.belowOfAligned(segmented, HorizontalAlignLeft)
.widthOf(segmented)
.pinEdges()
.marginTop(margin)
.sizeToFitType(FitWidth).layout();
separatorView.pinObjc
.belowOfViewsAligned(@[logo, textLabel], HorizontalAlignLeft)
.rightToEdge(segmented.edge.right)
.height(1)
.marginTop(margin).layout();
}

- (void) setLayoutGuidesTop:(CGFloat)top {
Expand Down
Loading