Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an appdata file #8

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Conversation

sanjayankur31
Copy link
Contributor

@jubalh
Copy link
Member

jubalh commented Mar 11, 2018

Nice, thanks!
Shouldnt there be a change in the project file to install this appdata file too?

Copy link
Member

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should go into the linux subfolder

</description>
<!-- no screenshots -->
<url type="homepage">https://lazarus-pkgs.github.io/lazarus-pkgs/panini.html</url>
<updatecontact>tksharpless@gmail.com</updatecontact>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas isn't the main contact for this anymore, please add my email instead (you can see it in git log).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

@sanjayankur31
Copy link
Contributor Author

Yeh, ideally, the project file should put it in %{_datadir}/metainfo/, where %{_datadir} usually expands to /usr/share. I can look into updating the pro file too. Should I? :)

This is the Fedora documentation on Appdata, for reference: https://fedoraproject.org/wiki/Packaging:AppData

</description>
<!-- no screenshots -->
<url type="homepage">https://lazarus-pkgs.github.io/lazarus-pkgs/panini.html</url>
<updatecontact>jubalh AT iodoru DOT org</updatecontact>
Copy link
Member

@jubalh jubalh Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it okay to write the email in such a format? I dont much about appdata, so not sure which formats the progams that parse that file will read it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the e-mail address is parsed at all currently. I did validated it and didn't get an error:

appstream-util validate-relax linux/panini.appdata.xml 
linux/panini.appdata.xml: OK

So I reckon it's OK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jubalh
Copy link
Member

jubalh commented Mar 11, 2018

Please squash the first 3 commits into one.

@jubalh jubalh merged commit 5f184c3 into lazarus-pkgs:master Mar 12, 2018
@jubalh
Copy link
Member

jubalh commented Mar 12, 2018

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants