Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to latest deps (axum, hyper, etc.) #8

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

kcking
Copy link
Contributor

@kcking kcking commented Dec 14, 2023

PENDING lambda-http update, opening as draft for now

@kcking
Copy link
Contributor Author

kcking commented Dec 14, 2023

Waiting on awslabs/aws-lambda-rust-runtime#749 to be merged

@lazear
Copy link
Owner

lazear commented Dec 14, 2023

Thanks - I was wondering what the best way to support axum 0.7 is: (a) just mandate that all future versions of this crate depend on 0.7, or (b) to select axum/hyper versions via features (I've seen a few other crates do this). The surface area of this crate is super tiny though, so I think it's probably ok to go with route (a). If you have thoughts, happy to hear them!

@kcking
Copy link
Contributor Author

kcking commented Dec 14, 2023

My first thought would be to increment the minor version of this crate to 0.6.x to signify a backwards-incompatible change upon merging this PR. Then if there are any bugs or significant features that make sense to add to older versions, those could be back-ported on a 0.5.x branch.

@lazear
Copy link
Owner

lazear commented Dec 14, 2023

Sounds good - lemme know when ready to merge and I'll pull the trigger!

@vagmi
Copy link

vagmi commented Dec 21, 2023

Thanks for this. I think awslabs/aws-lambda-rust-runtime#749 has been merged. It would be really cool to have a new release of axum-aws-lambda.

The upgrade to hyper v1 is backwards incompatible.
@kcking kcking marked this pull request as ready for review December 22, 2023 03:56
@kcking
Copy link
Contributor Author

kcking commented Dec 22, 2023

I just saw that a new lambda-http version was published to crates.io. This is now ready for review @lazear :)

@lazear lazear merged commit 32937a6 into lazear:master Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants