Added CSV file support [API, ImportForm] #4
Conversation
There was a problem hiding this comment.
Hi @zul110 , really appreciate your work on it, supporting csv is quite important to a lot of users.
Before I can merge your change, could you check my comments on some of your code, and let me know if they make sense to you.
Also please add test for your code, the current code coverage threshold is 90%, it maybe too high, you can adjust to 80% if you feel there's no sense to reach it.
Thanks a lot.
|
|
||
| ctx.request.body = body; | ||
|
|
||
| console.log(body); |
| source, | ||
| }; | ||
|
|
||
| ctx.request.body = body; |
There was a problem hiding this comment.
Can we try not to re-assign an object?
Maybe pass the whole context ctx to the service is not a good idea in the beginning, need to refactor the parameters passing to the service, then you can avoid reassigning the body.
| const type = ctx.request.files["source"].type; | ||
|
|
||
| // Read and parse file['source'] | ||
| const source = csvHelpers.readFile( |
There was a problem hiding this comment.
The csvHelpers could be a fileHelper or something, otherwise it looks weird to make it parse JSON file as well.
| return lines; | ||
| }; | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
I'm not sure whether this file could be moved to utils folder, maybe that's a good place for it. Also please add test cases for it.
|
Thanks @lazurey I'll update the request at the earliest, according to your feedback. Regards, |
|
Hey guys, is this still under development? Do we need someone to take over from here? I'd volunteer to do that since this is an important feature for us. |
I think you can go ahead, since it's long time no update. |
How is it going? Did you decide to create a new plugin? I am working on the same issue atm in our project. |
Hi @lazurey,
I was looking for a way to bulk import data into our CMS, and the closest working plugin was yours. Thank you for making it, and saving us some time :)
However, our requirement was to import the data from CSV files, and thus this modification to both the form and the API:
Form
I have allowed the form to accept both .csv and .json files, and added a small "detour" to the form when a CSV file is imported.
Basically, the imported CSV is first converted to an object, and the normal workflow resumes.
API
The API now checks for files passed along the form-data, specifically with "source" filed name, and once it finds it, it converts the CSV or JSON data into object, and replaces toe original request's body with the newly created object. This modification is to allow for the resumption of the original workflow.
I have tried to follow your style as much as possible, modify as little formatting as possible, and have not used any dependency, to have as fewer changes as possible, while adding a powerful feature (at least to me :))
Thought others might use this feature, too.
Please do reach out if there are any issues.
Regards,
Zul