Skip to content

fix: CRITICAL: Monomorphization type system fails systematically (fixes #1892) #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2025
Merged

fix: CRITICAL: Monomorphization type system fails systematically (fixes #1892) #1922

merged 2 commits into from
Oct 26, 2025

Conversation

@krystophny
Copy link
Contributor

@krystophny krystophny commented Oct 26, 2025

Summary

  • ensure call-signature tracking preserves return type strings and kinds
  • update monomorphization to clone parameters/results with concrete types and refresh call node inference
  • adjust codegen inference logic and regression tests to emit correct integer/real declarations

Verification

  • make test
    • Project compiled successfully; test_monomorphization now passes with integer+real declarations

@krystophny
fix(monomorphization): correct return type propagation (fixes #1892)
84d1049
@krystophny
refactor(semantic): extract call signature collection to separate module
5af1f5f 
Extract collect_call_signature and its helper functions from
semantic_analyzer.f90 into semantic_call_signature_collector.f90 to
reduce module size and improve code organization.

- New module: semantic_call_signature_collector.f90 (237 lines)
- semantic_analyzer.f90 reduced from 1562 to 1360 lines
- All tests pass, functionality preserved
@krystophny krystophny mentioned this pull request Oct 26, 2025
Closed
@krystophny krystophny merged commit 2ab6072 into main Oct 26, 2025
2 checks passed
@krystophny krystophny deleted the fix/issue-1892-monomorphization-type branch October 26, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krystophny