Skip to content

fix: CRITICAL: standardizer_declarations_core.f90 exceeds 1000-line (fixes #1917) #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2025
Merged

fix: CRITICAL: standardizer_declarations_core.f90 exceeds 1000-line (fixes #1917) #1944

merged 2 commits into from
Oct 26, 2025

Conversation

@krystophny
Copy link
Contributor

Summary

  • split declaration logic across focused modules (array, collection, inference, insertion, parsing, state, variables) to replace the monolithic core
  • updated facade module to re-export the same public API while keeping every component under CLAUDE size limits

Verification

  • make test

@krystophny
refactor(standardizer): split declarations core (fixes #1917)
03b66ef
@krystophny
fix: refactor oversized functions to meet 100-line limit (issue #1917)
5e8634b 
Extracted logical blocks from three oversized functions into private
helper subroutines to comply with the hard limit of 100 lines per function:

1. parse_dimension_attribute (176 -> 58 lines):
   - Extracted check_has_explicit_bounds() for bounds validation
   - Extracted parse_dim_string_to_array() for dimension parsing
   - Extracted validate_dimensions_match() for dimension comparison
   - Extracted create_dimension_literals() for AST node creation

2. set_array_properties_from_type (101 -> 60 lines):
   - Extracted count_array_dimensions() for dimension counting
   - Extracted extract_dimension_sizes() for size extraction

3. apply_type_string_to_decl (143 -> 59 lines):
   - Extracted parse_base_and_attributes() for type parsing
   - Extracted extract_kind_from_base() for kind extraction
   - Extracted remove_dimension_attrs() for attribute filtering
   - Extracted build_filtered_attrs() for attribute reconstruction

All functionality preserved, full test suite passes (100% success rate).
@krystophny krystophny merged commit b25b5ca into main Oct 26, 2025
2 checks passed
@krystophny krystophny deleted the fix/issue-1917-standardizer-core branch October 26, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@krystophny