Skip to content

fix: semantic analyzer helper functions exceed 100-line hard lim (fixes #1953) #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2025
Merged

fix: semantic analyzer helper functions exceed 100-line hard lim (fixes #1953) #1954

merged 2 commits into from
Oct 26, 2025
+700 −521

Conversation

@krystophny
Copy link
Contributor

Summary

  • split handle_previsit into focused helpers and added shared frame utilities to keep frames under the hard 100-line limit
  • extracted control-flow scheduling helpers to manage scopes, parameter propagation, and association traversal without duplication
  • refactored postvisit logic with dedicated finalizers for call, loop, and binary nodes while preserving existing unification behavior

Verification

  • make test

@krystophny krystophny changed the title fix: fix: semantic analyzer helper functions exceed 100-line hard lim (fixes #1953) fix: semantic analyzer helper functions exceed 100-line hard lim (fixes #1953) Oct 26, 2025
@krystophny
fix: split helpers to keep semantic_analyzer_infer_impl under hard limit
b7747a9 
Extracted infer_allocate_statement, ensure_string_literal_type, and
compute_string_literal_length to new semantic_analyzer_infer_helpers
submodule. This reduces semantic_analyzer_infer_impl from 1104 to 937
lines, bringing it under the 1000-line hard limit.
@krystophny krystophny merged commit 4a0e165 into main Oct 26, 2025
2 checks passed
@krystophny krystophny deleted the fix/issue-1953-semantic-analyzer-helpers branch October 26, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@krystophny