Fix or silence a few more tidy warnings

lballabio · Aug 5, 2024 · 855e7f4 · 855e7f4
1 parent c361cdf
commit 855e7f4
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/ql/experimental/math/laplaceinterpolation.cpp b/ql/experimental/math/laplaceinterpolation.cpp
@@ -145,7 +145,7 @@ for (auto const& m : map_)
  // handling of the "corners", all second derivs are zero in the op
  // this directly generalizes Numerical Recipes, 3rd ed, eq 3.8.6
  Real sum_corner_h =
- std::accumulate(corner_h.begin(), corner_h.end(), Real(0.0), std::plus<Real>());
+ std::accumulate(corner_h.begin(), corner_h.end(), Real(0.0), std::plus<>());
  for (Size j = 0; j < dim.size(); ++j) {
  std::vector<Size> coord_j(coord);
  coord_j[j] = corner_neighbour_index[j];

diff --git a/ql/instruments/makecds.cpp b/ql/instruments/makecds.cpp
@@ -64,7 +64,8 @@ namespace QuantLib {
  end = tradeDate + *tenor_;
  }
  } else {
- end = *termDate_;
+ // we have two exclusive constructors; if we don't have a tenor, we have a term date
+ end = *termDate_; // NOLINT(bugprone-unchecked-optional-access)
  }
 
  Schedule schedule(protectionStart, end, couponTenor_, WeekendsOnly(), Following,

diff --git a/ql/pricingengines/swap/discretizedswap.cpp b/ql/pricingengines/swap/discretizedswap.cpp
@@ -59,7 +59,7 @@ namespace QuantLib {
 
  // NOLINTNEXTLINE(readability-implicit-bool-conversion)
  auto includeTodaysCashFlows = Settings::instance().includeTodaysCashFlows() &&
- *Settings::instance().includeTodaysCashFlows();
+ *Settings::instance().includeTodaysCashFlows(); // NOLINT(bugprone-unchecked-optional-access)
 
  auto nrOfFixedCoupons = args.fixedResetDates.size();
  fixedResetTimes_.resize(nrOfFixedCoupons);

diff --git a/test-suite/quantlibbenchmark.cpp b/test-suite/quantlibbenchmark.cpp
@@ -121,6 +121,7 @@ namespace {
  Benchmark(Benchmark&& move) = default; 
  Benchmark& operator=(const Benchmark &other) = default;
  Benchmark& operator=(Benchmark &&other) = default;
+ ~Benchmark() = default;
 
  double getCost() const { return cost_; }
  std::string getName() const { return name_; }
@@ -262,8 +263,7 @@ namespace {
  std::string msg = "Unable to find the Boost test unit for Benchmark '";
  msg += b.getName();
  msg += "'";
- std::runtime_error err(msg);
- throw err;
+ throw std::runtime_error(msg);
  }
  }
  }
@@ -575,7 +575,7 @@ QL_BENCHMARK_DECLARE(RoundingTests, testClosest, 100000, 0.1);
 
 
 
-int main(int argc, char* argv[] ) 
+int main(int argc, char* argv[] )  // NOLINT(bugprone-exception-escape)
 {
  const std::string clientModeStr = "--client_mode=true";
  bool clientMode = false;

diff --git a/test-suite/quantlibglobalfixture.cpp b/test-suite/quantlibglobalfixture.cpp
@@ -103,7 +103,7 @@ QuantLibGlobalFixture::QuantLibGlobalFixture() {
  ? "reference date events are included,\n"
  : "reference date events are excluded,\n")
  << (settings.includeTodaysCashFlows()
- ? (*settings.includeTodaysCashFlows()
+ ? (*settings.includeTodaysCashFlows() // NOLINT(bugprone-unchecked-optional-access)
  ? "today's cashflows are included,\n"
  : "today's cashflows are excluded,\n")
  : "")
@@ -166,4 +166,4 @@ SpeedLevel speed_level(int argc, char** argv) {
  return Faster;
  }
  return Slow;
-}
+}