C++ fixes and missing implementations

[DmitriGoloubentsev]

Some errors detected by clang + some methods have declarations, but no implementations.

[boring-cyborg]

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

[CLAassistant]

All committers have signed the CLA.

[coveralls]

coverage: 72.499% (-0.003%) from 72.502%
when pulling e643159 on matlogica:upsteam-fixes
into e6885c7 on lballabio:master.

[lballabio]

Apologies—I'm closing and reopening the PR so hopefully it picks up the latest CI fixes from master.

[boring-cyborg]

Congratulations on your first merged pull request!

[DmitriGoloubentsev]

Thank you! I'll potentially have more suggestions. I managed to automatically generate QuantLib pybind11 bindings for Linux and Windows. This activity showed me some inconsistency between platforms. Specifically, long type is 4 bytes on Windows and 8 bytes on Linux. Perhaps we should use a type that is the same size on both platforms...

…

On Fri, May 3, 2024 at 2:02 PM boring-cyborg[bot] ***@***.***> wrote: Congratulations on your first merged pull request! — Reply to this email directly, view it on GitHub <#1957 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUEPTIGIUK4MPECME3CHPTZAODHXAVCNFSM6AAAAABGSSJWVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSHE3TKMJUGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[sweemer]

@DmitriGoloubentsev Which clang errors exactly did you see? If you used some special compiler options then maybe we should add them to the CI builds too.

[DmitriGoloubentsev]

@DmitriGoloubentsev Which clang errors exactly did you see? If you used some special compiler options then maybe we should add them to the CI builds too.

Hi @sweemer, these were not compilation errors, but linking errors actually. Some methods declared but miss implementations. So if no tests call these methods, we see no linking errors.