Update cmake policy #2102
Update cmake policy #2102
Conversation
.github/workflows/cmake.yml
Outdated
| @@ -90,6 +90,7 @@ jobs: | |||
| - name: Compile | |||
| env: | |||
| BOOST_ROOT: C:\local\boost | |||
| CMAKE_PREFIX_PATH: C:\local\boost\lib64-msvc-14.3\cmake\Boost-1.85.0 | |||
There was a problem hiding this comment.
It seems we're going from having to tell CMake fewer information to having to tell it more. How comes we have to be so specific? Shouldn't Boost install files where CMake can find them without having to specify the exact directory in the depths of the Boost folder?
There was a problem hiding this comment.
Actually, the purpose of the added code is to inform CMake of the location of BoostConfig.cmake, since CMake couldn’t locate it on its own. Do you have any suggestions for improving this workaround?
There was a problem hiding this comment.
I'm not sure. I would have thought that the Boost installer took care of putting BoostConfig.cmake somewhere where CMake can find it. If that's not the case, maybe we could do that ourselves? In any case, I'm kind of worried that people now would have to take new explicit steps when they upgrade Boost...
There was a problem hiding this comment.
I agree. The problem occurs when the operating system is Windows.(installing boost w/o pkg manager) Locally, I ran some tests with the raw CMakeLists.txt, but I couldn’t configure the project because, once again, CMake couldn’t find the correct location for BoostConfig.cmake. So, I temporarily added the absolute path in CMakeLists.txt (set(CMAKE_PREFIX_PATH "absolute path")), which seems like a poor solution to this issue.
There was a problem hiding this comment.
It might be a good question to ask on the Boost mailing list, what do you think?
There was a problem hiding this comment.
Actually, I don’t have any experience with contacting the Boost mailing list. I don’t think my solution is the best way to handle this issue, so I’ll look into the problem more carefully. I’ll also find out how to contact the Boost mailing list.
There was a problem hiding this comment.
Info are at https://www.boost.org/community/groups.html
There was a problem hiding this comment.
Perhaps, it improves the understanding if you set the environment variable Boost_DIR instead of CMAKE_PREFIX_PATH as it is a Boost specific hint where to search for BoostConfig.cmake.
It seems we're going from having to tell CMake fewer information to having to tell it more.
BOOST_ROOT becomes obsolete with the use of Boost_DIR (or CMAKE_PREFIX_PATH), we can remove it. So, at least we would be even regarding the amount of information we have to provide.
There was a problem hiding this comment.
Perhaps, it improves the understanding if you set the environment variable
Boost_DIRinstead ofCMAKE_PREFIX_PATHas it is a Boost specific hint where to search forBoostConfig.cmake.It seems we're going from having to tell CMake fewer information to having to tell it more.
BOOST_ROOTbecomes obsolete with the use ofBoost_DIR(orCMAKE_PREFIX_PATH), we can remove it. So, at least we would be even regarding the amount of information we have to provide.
Thanks. I will try with applying this comment.
|
|
jongbongan
force-pushed
the
update_cmake_policy
branch
from
27e697a
to
a0e9ba4
Compare
CMake prefers not to support FindBoost if its version is greater or equal to 3.30. Therefore, config-based find_package is preferred.
(https://cmake.org/cmake/help/latest/policy/CMP0167.html)
It will resolve the issue #2088