Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST fails when the parameters are too long. #172

Merged
merged 1 commit into from
Feb 20, 2016
Merged

POST fails when the parameters are too long. #172

merged 1 commit into from
Feb 20, 2016

Conversation

voidberg
Copy link
Contributor

When doing a POST request, the parameters are sent appended to the url as well. If the url is too large (e.g. over jetty's default 8192) then the request will fail with a "414 - Request-URI Too Large".

@nicolasembleton
Copy link
Collaborator

Thanks for the feedback. Will review that today.

On Sat, Jan 23, 2016, 03:31 Alexandru Badiu notifications@github.com
wrote:

When doing a POST request, the parameters are sent appended to the url as
well. If the url is too large (e.g. over jetty's default 8192) then the

request will fail with a "414 - Request-URI Too Large".

You can view, comment on, or merge this pull request online at:

#172
Commit Summary

  • Do not send the parameters in the url when using POST.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#172.

@nicolasembleton
Copy link
Collaborator

Would you mind posting an example of a schema and a long request? Even a data-filler script to help reproduce would be very useful. @voidberg

@voidberg
Copy link
Contributor Author

Here's an example: https://gist.github.com/voidberg/620b11405af1a1373e8a

You can test this against any instance that runs jetty, the schema doesn't matter since the request will not get to Solr.

@voidberg
Copy link
Contributor Author

voidberg commented Feb 3, 2016

This can also trigger another error, 413 Payload Too Large, if the size of the post data being repeated in the get request is too large.

@insilica
Copy link

AH! I ran into the exact same thing today and came to the exact same solution, opening #177. Will close that one.

Though the issue here could be 'query string appended to URL redundantly in post requests', as one could argue this is unexpected even for simple short queries.

nicolasembleton added a commit that referenced this pull request Feb 20, 2016
POST fails when the parameters are too long.
@nicolasembleton nicolasembleton merged commit 492937b into lbdremy:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants