Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numpy complex dtype deprecation warning #331

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix numpy complex dtype deprecation warning #331

merged 1 commit into from
Apr 4, 2022

Conversation

jccurtis
Copy link
Collaborator

@jccurtis jccurtis commented Mar 31, 2022 •
edited
Loading

Found by @sfaaland

@jccurtis jccurtis added the bug label Mar 31, 2022
@jccurtis jccurtis requested a review from jvavrek March 31, 2022 23:51
@jccurtis
Copy link
Collaborator Author

@jvavrek the tests for the iso quantity are failing. I haven't dug in more but this might be related to #325. Either way the change in this PR is for fitting so we should be able to merge safely.

@jvavrek
Copy link
Contributor

jvavrek commented Apr 1, 2022 •
edited
Loading

I think NNDC is just down, not much pytest-rerunfailures can do about that. I get similar errors locally on an older main

@jccurtis jccurtis force-pushed the fix-numpy-complex-dep-warning branch from e5c4c96 to 119092c Compare April 4, 2022 19:23
@jccurtis jccurtis merged commit 479a264 into main Apr 4, 2022
@jccurtis jccurtis deleted the fix-numpy-complex-dep-warning branch April 4, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvavrek jvavrek jvavrek approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jccurtis @jvavrek