Fix stable IsotopeQuantity #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix-stable-isoqty
cosama
requested changes
May 15, 2022
examples/isotopes.ipynb
Outdated
| @@ -12,7 +12,12 @@ | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
| "metadata": {}, | |||
| "metadata": { | |||
There was a problem hiding this comment.
Can you clean up the notebook? I think you need to run something like:
jupyter nbconvert --ClearMetadataPreprocessor.enabled=True isotopes.ypynbThere was a problem hiding this comment.
jupyter nbconvert --ClearMetadataPreprocessor.enabled=True --to notebook isotopes.ipynb
cosama
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the sub-issue in #325 where we were getting
nanfor a mass of a sample. The issue was with how stable isotopes were handled in the various mass/activity/atoms conversions.Coauthored with @cosama