Handle an apparent XCOM bug in energies list #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First energy in the list of user-specified energies seems to get discarded by the server. This is a kludge with a noisy warning to remind us to remove it when it gets fixed.
|
Apparently our tests have consistently been failing to due XCOM-related errors since August 1. |
|
The one failure is because I re-enabled |
jvavrek
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first energy in the list of user-specified energies seems to get discarded by the server. This is a kludge with a noisy warning to remind us to remove it when it gets fixed.
This kludge also works on the XCOM website query --- just add a "dummy" energy at the top of the "Additional energies in MeV" list.