-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spawn hangs if simulated past the RunPeriod in the idf file #1678
Comments
The development branch @kbenne : Please address this in the next build. Easiest is to verify with OpenModelica and look at the log file to see where it is stuck because JModelica and Dymola seems to buffer writing of the log file and you won't see the last output. Can you also avoid that EnergyPlus terminates, except when |
Before this change if EnergyPlus came to the end of the run period, threw an execption, or suffered a fatal error, then the control thread would just hang due to a deadlock. This should address that issue. A future change will make spawn/EnergyPlus ignore the run period completely. ref lbl-srg/modelica-buildings#1678
@mwetter I figured out how to reference issues across repositories. I'm hoping you are getting notifications about these changes I am making. |
@kbenne I did not see notifications, other than what you wrote on this repo. Also, if you write things like "This should be fully addressed with NREL/Spawn@26fd4ac" is there a way to get notified when it is ready in a built for download? (Even if by manual email.) |
I thought maybe my commit message would give you a notification as it did show up here since I tagged it with this issue number. I'm using All of these commits are being built by CI now. I'll look into automatically linking the builds from the commit using a GitHub badge (we do this for EnergyPlus and OpenStudio). Separately, I have been manually triggering the CI to post to the drop location under "latest" at intervals we agree on, and I will do that again soon as I'm wrapping up a huge batch of work. I will include a curated log message for you so you can see that commits and changes that you are interested in. |
This change means that it is *almost impossible to reach the end of the simulation period. Instead, spawn client will need to explicitly stop the simulation. This change also removes any preexisting run periods, although a future change might leave them and in turn create an api to select which runperiod that fmu will simulate. close lbl-srg/modelica-buildings#1678
Simulating
OneZoneOneOutputVariable
withcauses spawn to hang at 7 days, which is the end of the EnergyPlus run period in the idf file. However, EnergyPlus should ignore the RunPeriod and stop if when
fmi2Terminate
is called, see https://lbl-srg.github.io/soep/softwareArchitecture.html#time-synchronizationThe text was updated successfully, but these errors were encountered: