Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Delete and move articles #4

Merged
merged 11 commits into from
Feb 11, 2022
Merged

Conversation

lagartoverde
Copy link
Collaborator

Added 3 new functionalities:

  • Remove article
  • Move up article
  • Move down article

To discuss: Should we modify the article numbers when moving up and down?

@abeforgit
Copy link
Member

cfr our discussion, let's merge without handling article numbering, we can tackle that as a separate feature later on after finding out what users want

@abeforgit abeforgit added the enhancement New feature or request label Feb 9, 2022
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well overall, some quirks here and there which people will get annoyed by

addon/components/besluit-plugin-card.js Show resolved Hide resolved
addon/components/besluit-plugin-card.hbs Show resolved Hide resolved
addon/commands/move-article-command.js Show resolved Hide resolved
addon/commands/move-article-command.js Show resolved Hide resolved
@lagartoverde lagartoverde merged commit db15cf4 into master Feb 11, 2022
@elpoelma elpoelma deleted the feature/new-article-features branch September 21, 2022 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants